From bb1ffab8fc3669f0acb769bee460e573f471089b Mon Sep 17 00:00:00 2001
From: mlangkabel <malte.langkabel@gmail.com>
Date: Wed, 5 Aug 2026 19:54:43 +0200
Subject: [PATCH] fix a bug where view continues to pan when window lost focus
 while panning

---
 src/ui/GameWorldView.cpp | 13 +++++++++++++
 src/ui/GameWorldView.h   |  4 ++++
 2 files changed, 17 insertions(+)

diff --git a/src/ui/GameWorldView.cpp b/src/ui/GameWorldView.cpp
index 6b56bce..595dba2 100644
--- a/src/ui/GameWorldView.cpp
+++ b/src/ui/GameWorldView.cpp
@@ -18,6 +18,7 @@
 #include <QCursor>
 #include <QDir>
 #include <QFile>
+#include <QFocusEvent>
 #include <QFont>
 #include <QKeyEvent>
 #include <QLinearGradient>
@@ -2361,10 +2362,22 @@ void GameWorldView::keyReleaseEvent(QKeyEvent* event)
     }
     if (m_inputMapper.handleKeyRelease(event)) { return; }
     // Releasing Shift discards the copied building settings (REQ-BLD-COPY-CONFIG).
+    // Stays here rather than moving to the input mapper: Shift is the modifier of a
+    // mouse gesture, not a keyboard action of its own.
     if (event->key() == Qt::Key_Shift) { m_copiedConfig.reset(); }
     QOpenGLWidget::keyReleaseEvent(event);
 }
 
+void GameWorldView::focusOutEvent(QFocusEvent* event)
+{
+    // Without this, holding A while a modal opens (the escape menu, a schematic
+    // choice, game over) leaves the pan key held: the key-up goes to the dialog,
+    // never here, and the view pans on its own once the dialog closes. Panning runs
+    // on wall-clock time, so pausing does not mask it either.
+    m_inputMapper.releaseAll();
+    QOpenGLWidget::focusOutEvent(event);
+}
+
 void GameWorldView::mousePressEvent(QMouseEvent* event)
 {
     const WorldCoordinates coordinates = getCoordinates();
diff --git a/src/ui/GameWorldView.h b/src/ui/GameWorldView.h
index 532add0..1aa8858 100644
--- a/src/ui/GameWorldView.h
+++ b/src/ui/GameWorldView.h
@@ -107,6 +107,10 @@ protected:
     void paintGL() override;
     void keyPressEvent(QKeyEvent* event) override;
     void keyReleaseEvent(QKeyEvent* event) override;
+    // Key-up never arrives for a key that was still held when focus moved away —
+    // to a modal dialog, another widget, or another window. Any held action would
+    // otherwise stay held forever, so focus loss drops all of them.
+    void focusOutEvent(QFocusEvent* event) override;
     void mousePressEvent(QMouseEvent* event) override;
     void mouseMoveEvent(QMouseEvent* event) override;
     void mouseReleaseEvent(QMouseEvent* event) override;