Use std::optional instead of sentinel values for absent data

2026-07-20 20:27:20 +02:00
parent 1cdafb7bcd
commit 9622fa4345
32 changed files with 228 additions and 209 deletions
--- a/src/test/ShipTest.cpp
+++ b/src/test/ShipTest.cpp
@@ -224,7 +224,7 @@ TEST_CASE("ShipSystem: salvage_ship cargo capacity matches config", "[ship]")
    // Cargo capacity is now a ship-level pool (REQ-MOD-CARGO-CAPACITY).
    REQUIRE(admin.get<CargoComponent>(e).maxCapacity == 10);
    REQUIRE(admin.get<CargoComponent>(e).current     == 0);
-    REQUIRE(admin.get<DeliverScrapBehavior>(e).deliveryBay == kInvalidBuildingId);
+    REQUIRE_FALSE(admin.get<DeliverScrapBehavior>(e).deliveryBay.has_value());
    REQUIRE_FALSE(admin.get<SalvageScrapBehavior>(e).scrapTarget.has_value());
    REQUIRE(admin.get<SalvageScrapBehavior>(e).maxCollectionRange_tiles == Approx(50.0f));
 }