Derive ship scrap drop from threat

src/test/CombatSystemTest.cpp

@@ -14,6 +14,7 @@
 #include "HealthComponent.h"
 #include "HqProxyComponent.h"
 #include "ModuleOwnerComponent.h"
+#include "ScrapDataComponent.h"
 #include "ScrapSystem.h"
 #include "ShipSystem.h"
 #include "Simulation.h"
@@ -406,24 +407,19 @@ TEST_CASE("CombatSystem: scrap is spawned on ship death", "[combat]")
 {
     Simulation sim(loadConfig(), 42);
 
-    const ShipDef* droppingDef = nullptr;
-    for (const ShipDef& def : sim.config().ships.ships)
-    {
-        if (def.loot.scrapDrop > 0)
-        {
-            droppingDef = &def;
-            break;
-        }
-    }
-    REQUIRE(droppingDef != nullptr);
-
-    const entt::entity ship = sim.ships().spawn(droppingDef->id, 1,
+    // Scrap dropped on death is derived from the ship's as-built threat cost
+    // (REQ-RES-SCRAP-DROP): round(threat * scrap_per_threat). The interceptor's
+    // threat is 59.0 and the test config sets scrap_per_threat = 1.0, so it drops
+    // round(59.0 * 1.0) = 59 scrap.
+    const entt::entity ship = sim.ships().spawn("interceptor", 1,
         QVector2D(10.0f, 10.0f));
     sim.admin().get<HealthComponent>(ship).hp = -1.0f;
 
     sim.tick();
 
-    REQUIRE(!sim.scraps().allScrapInfo().empty());
+    const std::vector<ScrapInfo> scraps = sim.scraps().allScrapInfo();
+    REQUIRE(scraps.size() == 1);
+    CHECK(sim.admin().get<ScrapDataComponent>(scraps[0].entity).amount == 59);
 }
 
 TEST_CASE("CombatSystem: HQ death sets game over", "[combat]")