Fix Salvage Bay drop-off not working by adding config-driven buffer capacity

src/test/BehaviorSystemTest.cpp

@@ -984,6 +984,45 @@ TEST_CASE("BehaviorSystem: full-cargo salvage ship moves toward SalvageBay", "[b
     REQUIRE(i.target.x() < pos(f.admin, ship).value.x());
 }
 
+TEST_CASE("SalvagerSystem: full-cargo ship at its SalvageBay hands over cargo", "[behavior]")
+{
+    Fixture f;
+
+    const BuildingId bayId = f.buildings.place(BuildingType::SalvageBay,
+                                              QPoint(-4, 0), Rotation::East, 0);
+    Tick t = 0;
+    for (int i = 0; i < 500; ++i)
+    {
+        f.buildings.tickConstruction(t++);
+        if (f.buildings.findBuilding(bayId) != nullptr) { break; }
+    }
+    const Building* bay = f.buildings.findBuilding(bayId);
+    REQUIRE(bay != nullptr);
+    // Config-driven output-buffer capacity is applied on placement (REQ-BLD-SALVAGE-BAY).
+    REQUIRE(bay->outputBuffer.capacity == 20);
+
+    const QVector2D bayCenter(bay->anchor.x() + bay->footprint.width()  / 2.0f,
+                              bay->anchor.y() + bay->footprint.height() / 2.0f);
+
+    const ShipLayoutConfig salvageLayout = makeSingleModuleLayout("salvager");
+    const entt::entity ship = f.ships.spawn("salvage_ship", bayCenter, false, salvageLayout);
+    f.admin.get<PositionComponent>(ship).value = bayCenter;
+    CargoComponent& cargo = f.admin.get<CargoComponent>(ship);
+    cargo.current = cargo.maxCapacity;  // full cargo
+    const int before = cargo.current;
+    REQUIRE(before > 0);
+    f.admin.get<DeliverScrapBehavior>(ship).deliveryBay = bayId;
+
+    f.salvageTick();
+
+    // One unit handed over from cargo into the bay's output buffer.
+    REQUIRE(f.admin.get<CargoComponent>(ship).current == before - 1);
+    const Building* bayAfter = f.buildings.findBuilding(bayId);
+    REQUIRE(bayAfter != nullptr);
+    REQUIRE(bayAfter->outputBuffer.items.size() == 1);
+    REQUIRE(bayAfter->outputBuffer.items.front().type.id == "scrap");
+}
+
 // ---------------------------------------------------------------------------
 // Collection range (per-module)
 // ---------------------------------------------------------------------------

src/test/ConfigLoaderTest.cpp

@@ -103,6 +103,15 @@ TEST_CASE("ConfigLoader loads the committed bin/config/ configs end-to-end", "[c
     REQUIRE(minerIt != cfg.buildings.buildings.end());
     REQUIRE(minerIt->cost == 15);
     REQUIRE(minerIt->surfaceMask.size() == 2);
+    // Miner has no output-buffer-capacity override; the Salvage Bay does.
+    REQUIRE_FALSE(minerIt->outputBufferCapacity.has_value());
+
+    const auto salvageBayIt = std::find_if(
+        cfg.buildings.buildings.begin(), cfg.buildings.buildings.end(),
+        [](const BuildingDef& b) { return b.type == BuildingType::SalvageBay; });
+    REQUIRE(salvageBayIt != cfg.buildings.buildings.end());
+    REQUIRE(salvageBayIt->outputBufferCapacity.has_value());
+    REQUIRE(*salvageBayIt->outputBufferCapacity == 20);
 
     // recipes.toml — reprocessing cycle has three weighted outputs.
     const auto reproIt = std::find_if(